-
Notifications
You must be signed in to change notification settings - Fork 271
fix: Respect symbolic toolbar icons as fallback #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TODO: Add comment about this discussion and that this solution is a workaround and should be reverted if GNOME and/or Debian offer a long term solution. |
|
Hi. I just wanted to comment that I tested this new icon.py file on a fresh Debian 13 VM with Back in Time 1.5.5 installed. I found it does indeed fix the icons when running back in time as standard user. The symbolic icons now appear. However I found that when running as root (backintime-qt_polkit) the icons still don't show, get the error about no theme found in --debug output. What I found does fix this, is editing the icon.py file and adding 'Adwaita' (with a capital A) to the list of themes to search for. Example below: themes_to_try = ( Appears that when running as root via polkit the theme directories in /usr/share/icons are case sensitive. When running as standard user they are not. On Debian 13, in /usr/share/icons directory, Adwaita is spelt with captial A as below: user@debian:/usr/share/icons$ ls -alh Here is a before and after debug log running backintime-qt_polkit --debug: Before adding 'Adwaita' to list of themes to lookup: backintime-qt_polkit --debug Back In Time Back In Time comes with ABSOLUTELY NO WARRANTY. DEBUG: [common/configfile.py:585 Config.setCurrentProfile] Change current profile: 1=Main profile DEBUG: [common/tools.py:1121 is_Qt_working] Qt probing errout: DEBUG: [plugins/systrayiconplugin.py:68 init] No system tray available to show the BiT system tray icon After adding 'Adwaita' to list of themes to lookup: backintime-qt_polkit --debug Back In Time Back In Time comes with ABSOLUTELY NO WARRANTY. DEBUG: [common/configfile.py:585 Config.setCurrentProfile] Change current profile: 1=Main profile DEBUG: [common/tools.py:1121 is_Qt_working] Qt probing errout: DEBUG: [plugins/systrayiconplugin.py:68 init] No system tray available to show the BiT system tray icon |
|
Thank you for checking this out. I wonder if I might use all dir names in |
Symbolic icons now explicit used as fallback for icons in toolbar and elsewhere.
This is a workaround because Qt itself does ignore the concept of symbolic icons and does not check them by itself. This affects GNOME (Debian 13) users for example because it's adwaita icon theme is shipped with symbolic icons only.
Fix #2289